Updates for FileZilla_Server-0_9_54 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somwhere between FileZilla_Server-0_9_24 and FileZilla_Server-0_9_54 a status message changed from "226 Transfer OK" to "226 Successfully transferred". See ControlSocket.cpp of FileZilla_Server. Now successful transfers are found again.
|
Thanks for the pull request! I am wondering if opening the log files with utf-8 encoding will work for log files generated by older versions of FileZilla Server. |
|
This depends on the encoding FileZilla Server used back then. If it used plain US-ASCII for storing assuming utf-8 when opening should work. I believe the same is true for latin1 (aka "ISO 8859-1"). https://en.wikipedia.org/wiki/ISO/IEC_8859-1 If it used the system encoding of windows. Things will be tricky. https://en.wikipedia.org/wiki/Mojibake |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: No successful transfers were found as the text returned by FileZilla server changed for the "226" status code. (was "Transfer OK" now is "Successfully transferred")
fixed: By now FileZilla_Server (0_9_54) produces utf-8 log files. Decoding