Skip to content

Commit

Permalink
Force protobuf python implementation
Browse files Browse the repository at this point in the history
It seems that Anki 2.1.35 (the last version compatible with python3.7)
is not actually compatible with the latest protobuf (possibly released
after Anki 2.1.35).

See:
https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

Both anki and protobuf are dev dependencies so this incompatibility
only affects testing.

We will be able to remove this workaround by upgrading to
python3.9 (compatible with latest Anki).
  • Loading branch information
aplaice committed May 18, 2023
1 parent 0eab16d commit 432a67d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/mamba.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ jobs:
pipenv install --dev
# TODO Run each test separately? (See: #145.)
# TODO Remove PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python hack on upgrading python.
- name: Run tests
run: |
pipenv run mamba ./
PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python pipenv run mamba ./

0 comments on commit 432a67d

Please # to comment.