Update note, deck and model management for Anki 2.1.28+ #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a new model had an id of None, now it's 0. See: pylib/anki/media.py:171 in f637ac957d206ead619d54d6cf86eb8958ea508c
It's now required.
col.addNote() is legacy. note.flush() is now impossible (and unnecessary) for a new note.
Stvad
reviewed
Oct 12, 2020
crowd_anki/representation/note.py
Outdated
| elif not import_config.ignore_deck_movement: | ||
| self.move_cards_to_deck(deck.anki_dict["id"]) | ||
| if saner_note_addition: | ||
| collection.add_note(self.anki_object, deck.anki_dict["id"]) |
There was a problem hiding this comment.
does this mean we can directly specify the deck id, and so don't need the did magic above anymore?
There was a problem hiding this comment.
Yes.
I had wrapped the did magic so it only ran for old Anki versions, for compatibility, and now have completely removed it. (Unless I missed part of it.)
Switching to an explicit equality check in note_model.py is not necessary and arguably less "pythonic", but IMO clearer.
|
Thank you for contributing this! |
|
Thanks for merging, as well as for having created this incredibly valuable add-on in the first place! |
|
Uploaded new version to ankiweb |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #92.
Adjust check for "nullness" of model id
Previously, a new model had an id of None, now it's 0.
See:
pylib/anki/media.py:171in Anki itself (commit f637ac957d206ead619d54d6cf86eb8958ea508c).Pass deck to
collection.decks.save()It's now required.
Update note addition for Anki 2.1.28 and later
col.addNote()is legacy.note.flush()is now impossible (and unnecessary) for a new note.I've written this in a way to preserve compatibility with Anki 2.1.26 (and presumably earlier), since this made it easier to interactively test that behaviour was preserved.
This slightly complicates the code, so might not be desirable.
I think that the fix is correct (it seems to work for me, for both importing a fresh CrowdAnki deck and updating an existing one, for Anki 2.1.28, 2.1.34 and 2.1.35), but I'm not sure, as I'm not too familiar with either CrowdAnki or Anki's Note management (pre- or post- overhaul).
(
pipenv run mamba ./resulted in no errors.)