Don't suggest completions for internal rules or functions (#754)

Fixes #751

Signed-off-by: Anders Eknert <anders@styra.com>

internal/lsp/completions/providers/rulerefs.go

@@ -53,6 +53,12 @@ func (*RuleFromImportedPackageRefs) Run(
 				continue
 			}
 
+			// don't suggest refs of "private" rules, even
+			// if only just by naming convention
+			if strings.Contains(ref.Label, "._") {
+				continue
+			}
+
 			isFromImportedPackage := false
 
 			for _, i := range mod.Imports {

internal/lsp/completions/providers/rulerefs_test.go

@@ -25,6 +25,8 @@ func TestRuleFromImportedPackageRefs(t *testing.T) {
 		"file:///foo/foo.rego": `package foo
 
 bar := true
+
+_internal := true
 `,
 		"file:///bar/bar.rego": `package bar
 

internal/lsp/completions/refs/refs.go

@@ -5,7 +5,7 @@ import (
 	"slices"
 	"strings"
 
-	"gopkg.in/yaml.v2"
+	"gopkg.in/yaml.v3"
 
 	"github.com/open-policy-agent/opa/ast"
 

internal/lsp/completions/refs/refs_test.go

@@ -63,9 +63,9 @@ A package that's for things
 %s
 foo: bar
 tags:
-- a
-- b
-- c
+    - a
+    - b
+    - c
 %s
 `, "```yaml", "```"),
 		},

internal/lsp/types/internal.go

@@ -11,7 +11,7 @@ type Ref struct {
 	Label string
 	// Detail is a small amount of additional information about the object.
 	Detail string
-	// Description is a longer description of the object and us markdown formatted.
+	// Description is a longer description of the object and uses Markdown formatting.
 	Description string
 }