Inconsistencies with external-reference warning #719
Comments
|
Thanks @asleire! Yeah, the implementation of this rule is rather simplistic.. but I'm still surrpised by a few of these. We have a few rules that can't currently catch all violations — typically because it's really expensive to do so in some cases — but we'll always have zero tolerance for false positives. In this case it looks like we're already doing an expensive I'll take a look. |
The following cases are now covered:
```rego
f(_) := r
f(_) := {"r": r}
```
And variations thereof.
Fixes #719
Although it doesn't fix the `func_2` example there, this is about as
much we can do without some major effort.. so I'm not sure it's worth
keeping that issue open as I doubt we'll get there anytime soon.
Signed-off-by: Anders Eknert <anders@styra.com>
The following cases are now covered:
```rego
f(_) := r
f(_) := {"r": r}
```
And variations thereof.
Fixes #719
Although it doesn't fix the `func_2` example there, this is about as
much we can do without some major effort.. so I'm not sure it's worth
keeping that issue open as I doubt we'll get there anytime soon.
Signed-off-by: Anders Eknert <anders@styra.com>
|
PR up to fix every issue reported other than |
The following cases are now covered:
```rego
f(_) := r
f(_) := {"r": r}
```
And variations thereof.
Fixes StyraInc#719
Although it doesn't fix the `func_2` example there, this is about as
much we can do without some major effort.. so I'm not sure it's worth
keeping that issue open as I doubt we'll get there anytime soon.
Signed-off-by: Anders Eknert <anders@styra.com>
When linting my code I stumbled upon a case where I expected an external-reference warning, but there was none. I wrote a few test functions that I believe should trigger the warning but it doesn't
See play here: https://play.openpolicyagent.org/p/o5xBt1XUHP
func_3andfunc_5trigger warnings as expected, but the other funcs do notThe text was updated successfully, but these errors were encountered: