fix: Update root detection #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
approved these changes
Sep 4, 2024
|
|
||
| // 0 exit status is expected as all violations should have been fixed | ||
| expectExitCode(t, err, 0, &stdout, &stderr) | ||
|
|
||
| exp := fmt.Sprintf(`8 fixes applied: | ||
| In project root: %s | ||
| In project root: %[1]s |
There was a problem hiding this comment.
This should not be needed if only one
There was a problem hiding this comment.
But I guess if the linter isn't complaining, neither should I :)
There was a problem hiding this comment.
oops, that was a left over from having more than one root.
Now the .regal dir will be used as the root, unless it does not exist. If this is the case, then the roots will be used as the args to the fix cmd. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
force-pushed
the
fix-fix-root-detection
branch
from
350a430 to
7883261
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Now the .regal dir will be used as the root, unless it does not exist. If this is the case, then the roots will be used as the args to the fix cmd. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Now the .regal dir will be used as the root, unless it does not exist. If this is the case, then the roots will be used as the args to the fix cmd. Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the .regal dir will be used as the root, or any bundles configured under it or manually set in the file, unless it does not exist. If this is the case, then the roots will be used as the args to the fix cmd.