tests: Minor test wait improvement #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation would not exit after the timeout leading to test timeouts such as: https://github.com/StyraInc/regal/actions/runs/10940194447/job/30372056611 Which we are trying to avoid... Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
test-timeout
branch
from
1dfc3ab to
076ee76
Compare
anderseknert
approved these changes
Sep 19, 2024
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 24, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
The previous implementation would not exit after the timeout leading to test timeouts such as: https://github.com/StyraInc/regal/actions/runs/10940194447/job/30372056611 Which we are trying to avoid... Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
The previous implementation would not exit after the timeout leading to test timeouts such as: https://github.com/StyraInc/regal/actions/runs/10940194447/job/30372056611 Which we are trying to avoid... Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Built ins must now be provided by the caller. We have been having a number of issues where the shared list of builtins was required to be in a different state in different tests. Related StyraInc#1101 StyraInc#1102 StyraInc#1112 StyraInc#1121 StyraInc#1129 Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation would not exit after the timeout leading to test timeouts such as:
https://github.com/StyraInc/regal/actions/runs/10940194447/job/30372056611
Which we are trying to avoid...
The test goroutine was in /Users/runner/work/regal/regal/internal/lsp/server_test.go:435, so have targeted this part of the test.