Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

internal/lsp/hover: "fix" codeql finding #1156

Merged
merged 1 commit into from
Oct 1, 2024
Merged

internal/lsp/hover: "fix" codeql finding #1156

merged 1 commit into from
Oct 1, 2024

Conversation

srenatus
Copy link
Member

@srenatus srenatus commented Oct 1, 2024

Incorrect conversion of an unsigned 64-bit integer from to a lower bit size type uint without an upper bound check.

@srenatus
internal/lsp/hover: "fix" codeql finding
21de676 
Signed-off-by: Stephan Renatus <stephan@styra.com>
charlieegan3
charlieegan3 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@anderseknert anderseknert merged commit 06db4bb into main Oct 1, 2024
4 checks passed
@anderseknert anderseknert deleted the sr/parseuint branch October 1, 2024 10:26
srenatus added a commit to srenatus/regal that referenced this pull request Oct 1, 2024
@srenatus
internal/lsp/hover: "fix" codeql finding (StyraInc#1156)
76ed2f3 
Signed-off-by: Stephan Renatus <stephan@styra.com>
charlieegan3 pushed a commit to charlieegan3/regal that referenced this pull request Jan 6, 2025
@srenatus @charlieegan3
internal/lsp/hover: "fix" codeql finding (StyraInc#1156)
8802421 
Signed-off-by: Stephan Renatus <stephan@styra.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@charlieegan3 charlieegan3 charlieegan3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srenatus @charlieegan3 @anderseknert