Fix some minor issues reported by IntelliJ #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would be good to know why golangci-lint fails to report these, as some were fairly obvious. But oh well! Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
minor-fixes
branch
from
81d57e1 to
8de5355
Compare
srenatus
approved these changes
Oct 2, 2024
| @@ -50,9 +50,7 @@ func (r *PrettyReporter) ReportConflicts(fixReport *Report) error { | |||
| if len(roots) > 0 { | |||
| fmt.Fprintln(r.outputWriter, "Source file conflicts:") | |||
|
|
|||
| i := 0 | |||
|
|
|||
| for _, rootKey := range roots { | |||
There was a problem hiding this comment.
Looks like this just didn't work before? i was never increased...
There was a problem hiding this comment.
Indeed. Not too disastrous though as it was just for printing an extra newline between groups.
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Would be good to know why golangci-lint fails to report these, as some were fairly obvious. But oh well! Signed-off-by: Anders Eknert <anders@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be good to know why golangci-lint fails to report these, as some were fairly obvious. But oh well!
And