Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Custom rule authoring improvements #1168

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

anderseknert
Copy link
Member

Make code lens eval work in custom rules by adding the Regal bundle to the evaluation context if any custom rule is encountered.

Improve the docs based on feedback from @timothyhinrichs

Make code lens eval work in custom rules by adding the Regal bundle
to the evaluation context if any custom rule is encountered.

Improve the docs based on feedback from @timothyhinrichs

Signed-off-by: Anders Eknert <anders@styra.com>

You should now be able evaluate your custom rule against the `input.json` AST:

![Code Lens for Evaluation of custom rule](./assets/evalcustom.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is super nice!

@anderseknert anderseknert merged commit 8ca0197 into main Oct 3, 2024
4 checks passed
@anderseknert anderseknert deleted the custom-rule-improvements branch October 3, 2024 15:46
charlieegan3 pushed a commit to charlieegan3/regal that referenced this pull request Jan 6, 2025
Make code lens eval work in custom rules by adding the Regal bundle
to the evaluation context if any custom rule is encountered.

Improve the docs based on feedback from @timothyhinrichs

Signed-off-by: Anders Eknert <anders@styra.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants