Rule: walk-no-path
#1219
Merged
Rule: walk-no-path
#1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
approved these changes
Oct 23, 2024
|
The only thing I wondered about was showing the results of some testing to motivate this rule, e.g. |
Suggest replacing the path variable with a wildcard where possible, as the walk built-in is able to optimize such calls. More info in the docs included in the PR. Also: - Add `ast.is_wildcard` convenience function and use it consistently Fixes #1154 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
walk-no-path
branch
from
ca1acf4 to
4b3447b
Compare
|
@charlieegan3 added!
|
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Suggest replacing the path variable with a wildcard where possible, as the walk built-in is able to optimize such calls. More info in the docs included in the PR. Also: - Add `ast.is_wildcard` convenience function and use it consistently Fixes StyraInc#1154 Signed-off-by: Anders Eknert <anders@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest replacing the path variable with a wildcard where possible, as the walk built-in is able to optimize such calls. More info in the docs included in the PR.
Also:
ast.is_wildcardconvenience function and use it consistentlyFixes #1154