rule: Disable leaked_internal_reference for test files #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option added to turn back on if needed Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Oct 30, 2024
|
|
||
| In test files and packages, it can be useful to reference internal rules and | ||
| functions to ensure good test coverage. If you want to run this rule for test | ||
| files too, you can set `include-test-files: true` in the configuration for this |
There was a problem hiding this comment.
It isn't super clear here that this rule is disabled by default for tests. I'd put more emphasis on that, given that it's probably the only rule where that is the case.
There was a problem hiding this comment.
Yeah that's fair, I have updated in 1abaa96
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
* rule: Disable leaked_internal_reference for test files Option added to turn back on if needed Signed-off-by: Charlie Egan <charlie@styra.com> * Explain the rule is of by default for tests Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option added to turn back on if needed