lsp: Use notify for sending messages #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
force-pushed
the
notify-not-cal
branch
from
6f6935b to
fdaf7c6
Compare
anderseknert
approved these changes
Nov 18, 2024
Previously, we were using Call, this will wait for a request and can block. This PR uses Notify instead, which is non-blocking and follows the spec. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
force-pushed
the
notify-not-cal
branch
from
fdaf7c6 to
11764c1
Compare
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Previously, we were using Call, this will wait for a request and can block. This PR uses Notify instead, which is non-blocking and follows the spec. Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using Call, this will wait for a request and can block. This PR uses Notify instead, which is non-blocking and follows the spec.