Enable a few more golangci-lint rules #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
more-linters
branch
from
17bd573 to
db4415b
Compare
srenatus
approved these changes
Dec 3, 2024
Some of these were broken in the past. Enabling those now and one of them caught an actual issue, where we'd shadow the value of `err` in the command worker, and may not have some errors reported as we'd have expected. The nolintlint rule that checks ignore directives may turn out to be too annoying, but it was at least good to have it help clear out comments that were not redundant. Leaving it on for now and we can always disable if it turns out to be irritating. Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
more-linters
branch
from
db4415b to
850d8d0
Compare
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Some of these were broken in the past. Enabling those now and one of them caught an actual issue, where we'd shadow the value of `err` in the command worker, and may not have some errors reported as we'd have expected. The nolintlint rule that checks ignore directives may turn out to be too annoying, but it was at least good to have it help clear out comments that were not redundant. Leaving it on for now and we can always disable if it turns out to be irritating. Signed-off-by: Anders Eknert <anders@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these were broken in the past. Enabling those now and one of them caught an actual issue, where we'd shadow the value of
errin the command worker, and may not have some errors reported as we'd have expected.The nolintlint rule that checks ignore directives may turn out to be too annoying, but it was at least good to have it help clear out comments that were not redundant. Leaving it on for now and we can always disable if it turns out to be irritating.