Avoid allocations by not calling custom functions on hot path #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is absolutely wild 🙃
**Before**
```
BenchmarkRegalLintingItself-10 1 3245668375 ns/op 6689411656 B/op 127195706 allocs/op
```
**After**
```
BenchmarkRegalLintingItself-10 1 2777580459 ns/op 5235852824 B/op 107686435 allocs/op
```
And
```
hyperfine -i --warmup 1 'regal lint bundle' 'regal-new lint bundle'
Benchmark 1: regal lint bundle
Time (mean ± σ): 3.232 s ± 0.046 s [User: 22.535 s, System: 0.623 s]
Range (min … max): 3.169 s … 3.296 s 10 runs
Benchmark 2: regal-new lint bundle
Time (mean ± σ): 2.754 s ± 0.046 s [User: 18.641 s, System: 0.472 s]
Range (min … max): 2.689 s … 2.813 s 10 runs
Summary
regal-new lint bundle ran
1.17 ± 0.03 times faster than regal lint bundle
```
No @srenatus, I will not use benchstat! 🤣
Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
reviewed
Dec 6, 2024
srenatus
approved these changes
Dec 6, 2024
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
…nc#1289) This is absolutely wild 🙃 **Before** ``` BenchmarkRegalLintingItself-10 1 3245668375 ns/op 6689411656 B/op 127195706 allocs/op ``` **After** ``` BenchmarkRegalLintingItself-10 1 2777580459 ns/op 5235852824 B/op 107686435 allocs/op ``` And ``` hyperfine -i --warmup 1 'regal lint bundle' 'regal-new lint bundle' Benchmark 1: regal lint bundle Time (mean ± σ): 3.232 s ± 0.046 s [User: 22.535 s, System: 0.623 s] Range (min … max): 3.169 s … 3.296 s 10 runs Benchmark 2: regal-new lint bundle Time (mean ± σ): 2.754 s ± 0.046 s [User: 18.641 s, System: 0.472 s] Range (min … max): 2.689 s … 2.813 s 10 runs Summary regal-new lint bundle ran 1.17 ± 0.03 times faster than regal lint bundle ``` No @srenatus, I will not use benchstat! 🤣 Signed-off-by: Anders Eknert <anders@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is absolutely wild 🙃
Before
After
And
No @srenatus, I will not use benchstat! 🤣