lsp: Fix Code Lenses jank #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when editing a line, if parse errors come and go as you edit, the Code Lenses will toggle on and off as the parse error list is updated. Now, only if the line count is different from the last successful parse, will the Code Lenses be disabled. This means that a line can be typed while it contains errors, and code lenses will now come and go. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
jank-fix
branch
from
98ca21d to
4baf8c8
Compare
anderseknert
approved these changes
Feb 25, 2025
| @@ -47,6 +47,10 @@ type Cache struct { | |||
| // to be used for hover hints. | |||
| keywordLocationsFile *concurrent.Map[string, map[uint][]types.KeywordLocation] | |||
|
|
|||
| // when a file is successfully parsed, the number of lines in the file is stored | |||
| // here. This is used to gracefully fail when exiting unparsable files. | |||
| successfulParseLineCounts *concurrent.Map[string, int] | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when editing a line, if parse errors come and go as you edit, the Code Lenses will toggle on and off as the parse error list is updated.
Now, only if the line count is different from the last successful parse, will the Code Lenses be disabled.
This means that a line can be typed while it contains errors, and code lenses will now come and go.
Screen.Recording.2025-02-25.at.15.44.36.mov