Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: Make novelty package opt-in #1430

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

jalseth
Copy link
Contributor

@jalseth jalseth commented Mar 10, 2025

This allows Regal to be built without the go-asciisprite dependency.

@jalseth jalseth force-pushed the novelty-build-tag branch 2 times, most recently from c5c6786 to b03e14f Compare March 11, 2025 01:32
@srenatus
Copy link
Member

srenatus commented Mar 11, 2025

I'd like to understand the problem here. Is there a usecase where the go-asciisprite dependency is problematic?

@jalseth
Copy link
Contributor Author

jalseth commented Mar 11, 2025

For internal reasons, it is more work to have more dependencies, so I was hoping to remove this as a hard dependency for the tool. I spoke a bit with @anderseknert offline and and it sounds like the preference is to only have behavior like this as opt-out rather than opt-in, which doesn't help my use case. Going to close this for now.

@anderseknert
Copy link
Member

Eh, change of heart. If this makes things a little easier for you @jalseth , we can live with the fact that go build won't give you the festive output format. It's a secret easter egg anyway, and this way it'll be even more secret 😎

This allows Regal to be built without the go-asciisprite dependency.

Signed-off-by: James Alseth <jalseth@google.com>
@charlieegan3 charlieegan3 merged commit 52e1a39 into StyraInc:main Mar 13, 2025
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants