fix: Avoid panic in config finder #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
I think I'd use more path/filepath here (like https://pkg.go.dev/path/filepath#Dir), but since a minimal change is good, LGTM.
| @@ -139,6 +139,10 @@ func FindRegalDirectory(path string) (*os.File, error) { | |||
| return nil, errors.New("stopping as dir is empty string") | |||
| } | |||
|
|
|||
| if len(parts) < 2 { | |||
| return nil, errors.New("stopping as dir is root directory") | |||
| } | |||
There was a problem hiding this comment.
Is "root directory" well defined for windows? How about C:\ or D:\ or \\?
There was a problem hiding this comment.
Yeah, no idea. I hope this code isn’t permanent, as I’ll want to find out what’s going on here… but first to get a windows box somehow.
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Anders Eknert <anders@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it's worth having two different exit conditions, but I guess it doesn't hurt with some granularity?