lsp: Fix issue with parse error inlay hints #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the server to attempt a partial parse instead when there are parse errors to still, if possible, show the hints for sections of the file before the first parse error. This is a best effort adjustment, and if the parse still fails, all inlay hints are cleared until one or all of the parse errors are addressed. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
force-pushed
the
partial-inlay-hints
branch
from
9028274 to
66889a1
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
This change updates the server to attempt a partial parse instead when there are parse errors to still, if possible, show the hints for sections of the file before the first parse error. This is a best effort adjustment, and if the parse still fails, all inlay hints are cleared until one or all of the parse errors are addressed. Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
This change updates the server to attempt a partial parse instead when there are parse errors to still, if possible, show the hints for sections of the file before the first parse error.
This is a best effort adjustment, and if the parse still fails, all inlay hints are cleared until one or all of the parse errors are addressed.