lsp: Fix ast error line index bug #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
force-pushed
the
ast-error-issue
branch
from
36fe4f3 to
de68881
Compare
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
ast-error-issue
branch
from
de68881 to
b0a6326
Compare
anderseknert
approved these changes
May 22, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new file is created, it is empty. We need to address this since I think we are sent the contents. However, this is a fix for an index bug when processing these errors.
Before
Screen.Recording.2024-05-22.at.11.07.57.mov
After
Screen.Recording.2024-05-22.at.11.08.23.mov