lsp: Return copies of cache maps #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
reviewed
May 28, 2024
internal/lsp/cache/cache.go
Outdated
| @@ -84,7 +84,12 @@ func (c *Cache) GetAllFiles() map[string]string { | |||
| c.fileContentsMu.Lock() | |||
| defer c.fileContentsMu.Unlock() | |||
|
|
|||
| return c.fileContents | |||
| cp := make(map[string]string, len(c.fileContents)) | |||
There was a problem hiding this comment.
I believe we could use maps.Clone for this
There was a problem hiding this comment.
Ooh go is cool now.
There was a problem hiding this comment.
I have added this in 14290c4
anderseknert
approved these changes
May 28, 2024
charlieegan3
force-pushed
the
return-map-copies
branch
from
3724aa4 to
5175807
Compare
Addressing: StyraInc#750 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
return-map-copies
branch
from
5175807 to
14290c4
Compare
anderseknert
approved these changes
May 28, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Addressing: StyraInc#750 Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #750