cmd/fix: Filter files loaded for fixing #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the same logic to filter files when loading them for fixing as used in linting. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
commented
May 28, 2024
| @@ -28,6 +28,10 @@ func (*UseAssignmentOperator) Fix(fc *FixCandidate, opts *RuntimeOptions) ([]Fix | |||
|
|
|||
| line := lines[loc.Row-1] | |||
|
|
|||
| if loc.Col-1 < 0 || loc.Col-1 >= len(line) { | |||
There was a problem hiding this comment.
I ran into this running fix on a large rego codebase where another fix had shifted the contents for that run.
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
This uses the same logic to filter files when loading them for fixing as used in linting. Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same logic to filter files when loading them for fixing as used in linting.
Fixes: #761