lsp: Rule head & input doc completion improvements #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
force-pushed
the
rule-head-improvements
branch
from
e5c277b to
d70e6e6
Compare
These new completion providers will complete keywords and common rule names in a limited number of but common scenarios. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
rule-head-improvements
branch
from
d70e6e6 to
600a47e
Compare
Fixes: StyraInc#768 Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
changed the title
Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
May 29, 2024
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
May 30, 2024
Not sure how this got missed in StyraInc#773 but here it is now. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
that referenced
this pull request
May 30, 2024
Not sure how this got missed in #773 but here it is now. Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
These new completion providers will complete keywords and common rule names in a limited number of but common scenarios. Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Not sure how this got missed in StyraInc#773 but here it is now. Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new completion providers will complete keywords and common rule names in a limited number of but common scenarios.
Screen.Recording.2024-05-29.at.17.28.42.mov
also
Fixes #768
Screen.Recording.2024-05-29.at.17.49.27.mov