Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Notify fix failure #955

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

charlieegan3
Copy link
Member

@charlieegan3 charlieegan3 commented Aug 1, 2024

Fixes #944

Screen.Recording.2024-08-01.at.10.36.50.mov

This will now send an LSP notification to the editor when there is a
failure during fixing. Before, only a server log message was sent.

Signed-off-by: Charlie Egan <charlie@styra.com>
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anderseknert anderseknert merged commit 4f86595 into StyraInc:main Aug 1, 2024
3 checks passed
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
This will now send an LSP notification to the editor when there is a
failure during fixing. Before, only a server log message was sent.

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit to charlieegan3/regal that referenced this pull request Jan 6, 2025
This will now send an LSP notification to the editor when there is a
failure during fixing. Before, only a server log message was sent.

Signed-off-by: Charlie Egan <charlie@styra.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format code action (and the rego v1 formatting action) should report errors from formatting
2 participants