LSP: Provide output.json option for non-VS Code clients #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
reviewed
Aug 7, 2024
charlieegan3
reviewed
Aug 7, 2024
| value := result.Value | ||
| if result.IsUndefined { | ||
| // Display undefined as an empty object | ||
| // we could also go with "<undefined>" or similar |
There was a problem hiding this comment.
I quite like the idea of calling it undefined rather than the empty object myself...
There was a problem hiding this comment.
I'm not too sure, as it makes it hard to differentiate from the actual string value of "undefined"...
Using "" as print does is a little better. But for now I went with empty object as that's what opa eval prints by default, e.g.
> opa eval input.foo
{}
And use a reader instead of a string for input as suggested by @charlieegan3 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
code-lens-continued
branch
from
c5a68ca to
911651e
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
And use a reader instead of a string for input as suggested by @charlieegan3 Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
And use a reader instead of a string for input as suggested by @charlieegan3 Signed-off-by: Anders Eknert <anders@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use a reader instead of a string for input as suggested by @charlieegan3