Last minute additions #2217
Last minute additions #2217
Conversation
| // Constructor for serialization. Has to be "protected" for json serialization. | ||
| } | ||
| [DataMember(Order = 2)] | ||
| public string PathFromRoot { get; } |
There was a problem hiding this comment.
This metadata is applied to an object which doesn't necessarily hold the KeypadDoorConsole component. Thus we need a way to find the component, which varies from one prefab to another
There was a problem hiding this comment.
Can we not do this by extracting it from the object it's on rather than using the path?
There was a problem hiding this comment.
GetComponentInChildren is quite costy and might pick the wrong door is there are two available in the children
| { | ||
| Entities entities = NitroxServiceLocator.LocateService<Entities>(); |
There was a problem hiding this comment.
You should be using dependency injection, this will generate a warning from our analyzers
There was a problem hiding this comment.
It won't work in this static context
There was a problem hiding this comment.
Terrain is already being required inside Mutiplayer mb, so static can be removed
I might want to add a things or two before release which I'll put in here