Use vnl_sparse_matrix::get in ComputeJacobianTerms::Compute()
#1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just use `m_Scales` instead.
`vnl_sparse_matrix::get(r, c)` just returns when the entry isn't there, and it returns immediately when the row is empty. A performance improvement may not be noticeable, but it won't harm.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vnl_sparse_matrix::get(r, c)just returns zero when the entry isn't there, and it returns immediately when the row is empty.The performance of
vnl_sparse_matrix::getwas improved by:vnl_sparse_matrix::get(r, c), let "const"operator()overload callget(r, c)vxl/vxl#932 commit vxl/vxl@b37c7a2A performance improvement may not be noticeable, but it won't harm.