Show progress percentage only when requested by user #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check if `std::cout.tellp() == -1` does not work (anymore...) Addresses issue #756 "Executable progress indication appears suppressed on Windows".
|
FYI, A more fancy progress monitor was proposed to spdlog, but rejected: issue gabime/spdlog#854 and gabime/spdlog#1030 by Elmar Pruesse |
|
Superseded by pull request #832 Support "ShowProgressPercentage" parameter (false by default), which adds an elastix parameter, instead of command-line option or On/Off member functions |
|
Closed: abandoned, as it is superseded by pull request #832 Support "ShowProgressPercentage" parameter (false by default) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, during a time consuming process, the progress percentage was shown only by elastix/transformix executables, not by the library. Moreover, it was then only shown if
std::cout.tellp()would return -1. The return value ofstd::cout.tellp()appears platform dependent, and it does not really tell if showing the progress percentage is desirable. For details, see issue #756 "Executable progress indication appears suppressed on Windows".This pull request proposes to add an extra
boolflag to ourelx::logclass which specifies whether the user wants to see a progress percentage.It extends the executable interface with an option
-progress on, and it addsShowProgressPercentageOn/Offmember functions to the ITKElastix/library interface. By default, the progress percentage is not shown (which was the behavior on Windows until now anyway).