Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): update dependencies and bump release #82

Merged
merged 3 commits into from
Jul 18, 2017

Conversation

kalinchernev
Copy link
Contributor

Bumps package version to latest release. It's not +1 since a merge of #77 happened later than other releases in the meantime.

Updates package to latest versions. Most importantly, we have to upgrade commander to avoid this security issue.

Copy link
Contributor

@drGrove drGrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to use yarn.lock, should we not just pin all versions as well then?

package.json Outdated
"express",
"swagger"
],
"keywords": ["jsdoc", "restful", "api", "express", "swagger"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep new lines between items in array?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drGrove I reverted both changes.

@drGrove
Copy link
Contributor

drGrove commented Jul 12, 2017

Circle CI looks to be failing due to the version of node we're running vs the version of node expected for babylon.

@kalinchernev
Copy link
Contributor Author

Unfortunetely the build is failing, and I can't do anything about it because I don't have sufficient rights to do anything in CirlceCI. It's also normal for the version of node to be a questionable part of the stack. I previously touched both topics in #76
The situation is a reason for me to stop taking actions on this repo since I can't really fix issues like these.

@chdanielmueller
Copy link
Member

chdanielmueller commented Jul 18, 2017

Hi @kalinchernev
You can change the CircleCI config in https://github.com/Surnet/swagger-jsdoc/blob/master/circle.yml
There is a migration guide if we would like to use the new advanced features of CircleCI 2.0 https://circleci.com/docs/2.0/migrating-from-1-2/
What do you need me to do? I would be glad to help you.
Thanks,
Daniel

@chdanielmueller chdanielmueller merged commit ed21dc9 into master Jul 18, 2017
chdanielmueller added a commit that referenced this pull request Jul 18, 2017
@kalinchernev kalinchernev deleted the chore/release-dependencies branch July 18, 2017 17:12
@kalinchernev
Copy link
Contributor Author

Hi @chdanielmueller the master seems ok, thanks for following up here.
I haven't had the time to investigate the new circle ci topics, but most importantly the master seems stable. Please don't forget to publish the latest package to npm and the releases :)

@drGrove
Copy link
Contributor

drGrove commented Jul 18, 2017

@kalinchernev @chdanielmueller publishing v1.9.6 now

@kalinchernev
Copy link
Contributor Author

It will have to be 1.9.7. After this, you'll have to sync the master of the repo as before. Preferably, each release on npm has to be matched as a release in the repo. The timeline shows some examples which worked before the master was locked. Last time I tried, I couldn't make this follow-up on the master here. (The time I tried to keep a changelog)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants