-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(deps): update dependencies and bump release #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to use yarn.lock, should we not just pin all versions as well then?
package.json
Outdated
"express", | ||
"swagger" | ||
], | ||
"keywords": ["jsdoc", "restful", "api", "express", "swagger"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep new lines between items in array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @drGrove I reverted both changes.
Circle CI looks to be failing due to the version of node we're running vs the version of node expected for babylon. |
Unfortunetely the build is failing, and I can't do anything about it because I don't have sufficient rights to do anything in CirlceCI. It's also normal for the version of node to be a questionable part of the stack. I previously touched both topics in #76 |
Hi @kalinchernev |
This reverts commit ed21dc9.
Hi @chdanielmueller the master seems ok, thanks for following up here. |
@kalinchernev @chdanielmueller publishing v1.9.6 now |
It will have to be 1.9.7. After this, you'll have to sync the master of the repo as before. Preferably, each release on npm has to be matched as a release in the repo. The timeline shows some examples which worked before the master was locked. Last time I tried, I couldn't make this follow-up on the master here. (The time I tried to keep a changelog) |
Bumps package version to latest release. It's not +1 since a merge of #77 happened later than other releases in the meantime.
Updates package to latest versions. Most importantly, we have to upgrade commander to avoid this security issue.