This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Added a test for simultaneous async await #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! On that note, you might've noticed, that the unittest-results are also generated when tests fail. I think ill make a branch with all failing tests (that are currently disabled) enabled, so that we can see what currently doesn't work, and more easily track progress. This branch would then be updated from Any suggestions as for the branch name? |
ProphetLamb
approved these changes
Sep 29, 2022
|
Sounds good, something simple like |
43 tasks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running this test with code from before the RPC pooling fails with:
Now with pooling the test goes green.
Good to see that the pooling is working, nice work!