Improve Playwright handling #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Syer10
commented
Jan 7, 2023
Syer10
commented
- In bundlers pre-install Chromium
- Only ever download chromium, other browsers are skipped
AriaMoradi
requested changes
Jan 7, 2023
| < try (FileSystem fileSystem = "jar".equals(uri.getScheme()) ? FileSystems.newFileSystem(uri, Collections.emptyMap()) : null) { | ||
| --- | ||
| > try (FileSystem fileSystem = "jar".equals(uri.getScheme()) ? initFileSystem(uri) : null) { | ||
| /** |
There was a problem hiding this comment.
can we use be a better approach? i.e. running Chromium.preinstall in serverSetup
I prefer to not have a custom DriverJar for playwright
There was a problem hiding this comment.
We cannot, we need a custom DriverJar so that we make it only install chromium(line 96)
server/src/main/kotlin/eu/kanade/tachiyomi/network/interceptor/Chromium.kt
Outdated
Show resolved
Hide resolved
AriaMoradi
approved these changes
Jan 7, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.