Do not count mangas as part of categories that aren't in the library #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is tachiyomi behavior that we are reproducing. We should try working around this, unless there is a good reason to not to. cc: @Syer10 |
|
Yes this is intenional behavior, I would suggest modifying the size calculation to only include in-library manga instead. |
schroda
force-pushed
the
fix/manga_still_in_category_after_removal_from_library
branch
from
36a0142 to
cc21bfa
Compare
|
changed but what is the use case of this behaviour - that the categories are "restored" when adding it back to the library? |
Otherwise, the returned "size" of a property doesn't match the actual manga list, since that list only includes mangas from the library
schroda
force-pushed
the
fix/manga_still_in_category_after_removal_from_library
branch
from
cc21bfa to
84c6b84
Compare
schroda
changed the title
|
Yes, instead of using the default categories, it should use the previously selected categories |
schroda
deleted the
fix/manga_still_in_category_after_removal_from_library
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the "size" calculation of categories is wrong, since it includes mangas that aren't in the library anymore and won't be returned in the list of mangas of a category