Fix/ha scheduler not triggering missed executions due to not meeting the threshold #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was incorrectly considered to be met in case the remaining time till the next execution was less than the threshold. Instead, it has to be greater, since that would mean, that the next execution is taking long enough to not be triggering a double execution Thus, the current logic is not, as intended, preventing possible double executions and instead is making sure to only execute missed tasks in case it will lead to double executions...
The idea to have a threshold to prevent double executions in case the next scheduled execution isn't too far in the future doesn't really work with big intervals (e.g. in the days range). For such cases, multiple days left for the next executions could be considered to cause double executions. Decreasing the threshold doesn't really work since then it wouldn't really work for low intervals. Instead, it makes more sense to just allow possible double executions and to just live with it. In case it would be a problem for a specific task, the task should handle this issue itself.
Syer10
approved these changes
Jul 23, 2023
schroda
deleted the
fix/ha_scheduler_not_triggering_missed_executions_due_to_not_meeting_the_threshold
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.