Correctly emit changed values #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syer10
reviewed
Aug 12, 2023
| @@ -108,7 +109,8 @@ class ServerConfig(getConfig: () -> Config, val moduleName: String = SERVER_CONF | |||
| } | |||
|
|
|||
| val sharedFlow = MutableSharedFlow<T>(extraBufferCapacity = 1, onBufferOverflow = BufferOverflow.DROP_OLDEST) | |||
| actualFlow.distinctUntilChanged().onEach { sharedFlow.emit(it) }.launchIn(mutableConfigValueScope) | |||
| actualFlow.distinctUntilChanged().onEach { mutableConfigValueScope.launch { sharedFlow.emit(it) } } | |||
There was a problem hiding this comment.
I think changing it to mapLatest would be a better solution
"SharedFlow::emit" blocked the flow due not being called in a new coroutine.
schroda
force-pushed
the
fix/listening_to_server_setting_changes
branch
from
9486cea to
6390f88
Compare
Syer10
approved these changes
Aug 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"SharedFlow::emit" blocked the flow due not being called in a new coroutine.