Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/update react scripts dependency #255

Merged
merged 6 commits into from
Mar 11, 2023
Merged

Fix/update react scripts dependency #255

merged 6 commits into from
Mar 11, 2023

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Mar 5, 2023

upgrade to latest "react-script" version fixes the build error "error:0308010C:digital envelope routines::unsupported"

the latest version of "react-script" uses "eslint" v8, causing an error when building "... ERROR in Plugin "react" was conflicted between ".eslintrc.js" >> eslint-config-airbnb ...", thus, "eslint" has to be updated as well to be able for the latest "react-script" version to work without errors.

schroda added 4 commits March 5, 2023 15:08
Makes it easier to have a quick overview
With new versions of node (> v16) the build scripts fails with the following error "error:0308010C:digital envelope routines::unsupported"
The latest version of "react-scripts" uses eslint v8 causing the following error "... ERROR in Plugin "react" was conflicted between ".eslintrc.js" >> eslint-config-airbnb ..."
@schroda schroda changed the title Fix/update react scripts dependency [WIP] Fix/update react scripts dependency Mar 5, 2023
@schroda schroda changed the title [WIP] Fix/update react scripts dependency Fix/update react scripts dependency Mar 10, 2023
@schroda schroda marked this pull request as ready for review March 10, 2023 23:10
Copy link
Contributor

@akabhirav akabhirav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AriaMoradi AriaMoradi merged commit 23001a4 into Suwayomi:master Mar 11, 2023
@schroda schroda mentioned this pull request Mar 11, 2023
AriaMoradi pushed a commit that referenced this pull request Mar 11, 2023
#255 accidentally added a console log which caused the build to fail
@schroda schroda deleted the fix/update_react_scripts_dependency branch March 11, 2023 22:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants