Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

try fix #30 #31

Merged
merged 1 commit into from
Sep 17, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
try fix #30
This ensures `<input>` gets rendered first before `input?.addEventListener` gets called
  • Loading branch information
phanirithvij authored Sep 17, 2021

Verified

This commit was signed with the committer’s verified signature.
schroda schroda
commit e19cc347163c7fbc2a13a10b0741295a333f1cd3
2 changes: 1 addition & 1 deletion src/screens/manga/MangaExtensions.tsx
Original file line number Diff line number Diff line change
@@ -146,7 +146,7 @@ export default function MangaExtensions() {
document.removeEventListener('dragover', dragOverHandler);
input?.removeEventListener('change', changeHandler);
};
}, []);
}, [extensions]); // useEffect only after <input> renders

if (Object.entries(extensions).length === 0) {
return <h3>loading...</h3>;