Added pagination in getInbox. #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getInbox function now accepts two arguments: start and limit (both integers) start - Specifies the starting index of the results. (index starts from 0) limit - Specifies how many elements we want after the start value. -1 for infinite. For example: start = 10 and limit = 4 will return the 11th, 12th,13th and 14th elements.
|
Have you tested? |
|
No, not on your version, but have tested on python version. Have used same logic in both versions. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getInbox function now accepts two arguments: start and limit (both integers)
start - Specifies the starting index of the results. (index starts from 0)
limit - Specifies how many elements we want after the start value. Use -1 for infinite. The default value is 50.
For example: start = 10 and limit = 4 will return the 11th, 12th,13th and 14th elements.