Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Arduino MCP4728 #29

Merged
merged 11 commits into from
Feb 1, 2024
Merged

Arduino MCP4728 #29

merged 11 commits into from
Feb 1, 2024

Conversation

franz-sweepMe
Copy link
Contributor

@franz-sweepMe franz-sweepMe commented Jan 30, 2024 •
edited
Loading

Add driver to control up to 8 MCP4728 boards using Arduino

@franz-sweepMe
Arduino-MCP4728
e1cc738 
set GUI parameters, set reference voltage, enable single channel setting, multi channel setting, multi board setting, enable multiple instances in SweepMe
@franz-sweepMe
Arduino_MCP4728
d9f0bcd 
Commenting and Formatting, call() returns input values
@franz-sweepMe
Arduino_MCP4728
d79ba2a 
Update description
@franz-sweepMe
Arduino_MCP4728
d41f98e 
update license
@franz-sweepMe
initialize variables and units
3cfddb4
@franz-sweepMe
call returns self.values
7098551
@franz-sweepMe franz-sweepMe requested a review from a team as a code owner January 30, 2024 14:52
afischer-sweepme
afischer-sweepme requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@afischer-sweepme afischer-sweepme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is already a nice and clean driver. Adding a short pysweepme example to the folder "examples" could be helpful if you have already one.

afischer-sweepme
afischer-sweepme requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@afischer-sweepme afischer-sweepme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a minor remaining point

@franz-sweepMe franz-sweepMe merged commit d122adc into main Feb 1, 2024
2 checks passed
@franz-sweepMe franz-sweepMe deleted the Arduino_MCP4728 branch February 1, 2024 06:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fk3 fk3 fk3 left review comments

@afischer-sweepme afischer-sweepme afischer-sweepme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franz-sweepMe @fk3 @afischer-sweepme