Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Release 1.0.2 #34

Merged
merged 2 commits into from
May 1, 2017
Merged

Release 1.0.2 #34

merged 2 commits into from
May 1, 2017

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Apr 28, 2017 •
edited
Loading

Closes #33 \cc @ilyapuchka

After merge:

  • pod trunk push
  • rake changelog:reset

@AliSoftware AliSoftware requested a review from djbe April 28, 2017 11:38
@djbe
Copy link
Member

djbe commented Apr 28, 2017

Could it be that you have an older CocoaPods? The diff on the generated xcode project implies that you do.

Also, maybe merge #12 before this release, unless you want to make some modifications?

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Apr 28, 2017 •
edited
Loading

Just updated to cp 1.0.2 1.2.1 before doing my pod update StencilSwiftKit and version in Podfile.lock seems to match?

About #12 wasn't sure it was finished?

@djbe
Copy link
Member

djbe commented Apr 28, 2017 •
edited
Loading

Dunno, both the filters and the tags are documented (even the new map tag).

CocoaPods 1.0.2? You probably mean 1.2.0? The only reason I mentioned it, was because of the Pods.xcodeproj changes, which seem to go down an Xcode version.

@AliSoftware
Copy link
Contributor Author

I actually meant 1.2.1 😄

$ pod --version
1.2.1

@djbe
Copy link
Member

djbe commented Apr 28, 2017

Huh, weird. Anyway, when I try a pod install/update, nothing changes, so ignore what I said about CocoaPods.

@AliSoftware AliSoftware force-pushed the release/1.0.2 branch 2 times, most recently from 912a32f to 21c2c2a Compare April 30, 2017 18:31
@AliSoftware
Copy link
Contributor Author

We should merge #36 first; then rebase this release on top of that (or merge master into this release) and merge/deploy the release to CP 😉

@AliSoftware
Copy link
Contributor Author

@djbe please tell me once you've approved/merged #36 and (rebased and) approved the current #34 and I'll do a new release in CP right after :)

@AliSoftware AliSoftware modified the milestone: 1.0.2 May 1, 2017
@AliSoftware AliSoftware merged commit 1eaf697 into master May 1, 2017
@AliSoftware AliSoftware deleted the release/1.0.2 branch May 1, 2017 19:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@djbe djbe Awaiting requested review from djbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AliSoftware @djbe