Hotfix for jsonld context #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Merged
|
would it be easier to review if the PR was made to the branch of #765? |
rokroskar
changed the base branch from
master
to
99-import-dataset-from-renku-aware-repo
Panaetius
force-pushed
the
hotfix-jsonld-context
branch
from
09f1564 to
dee76a9
Compare
Panaetius
changed the base branch from
99-import-dataset-from-renku-aware-repo
to
master
rokroskar
reviewed
Nov 5, 2019
rokroskar
force-pushed
the
hotfix-jsonld-context
branch
from
bb5ac38 to
44e6f16
Compare
rokroskar
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
This makes sense to me although it makes the contexts complicated - they are not, however, really meant to be human-readable so it's not a huge problem for me. Additionally it could be cleaned up if we published the contexts (together with SHACL from #767) then they don't have to be inlined like they are here but simply linked.
The entities cleanup/refactoring is also a welcome change. 👍 Thanks!
jsam
approved these changes
Nov 7, 2019
mohammad-alisafaee
approved these changes
Nov 7, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
@contextin KG nested and type specific, solving issues of name collisions and missing triples.See https://www.w3.org/TR/json-ld11/#scoped-contexts for details on scoping contexts.
In-Depth description of problem&solution:
E.g.
Generation.entitycan refer to different python classes which can occur side by side. In order to process the KG, we need to combine all JSON values in the KG with their semantic type (coming from an Ontology). We have to deal with ambiguities, likesomething.projectreferring toschema:projectin one place andsomethingelse.projectreferring tofoaf:projectsomewhere else. To deal with this, we need to use local, scoped contexts that are only applicable for a single class, not some global context that's applicable to everything. We achieve vertical scoping (A child class having the same property as parent but with different semantics) by nesting contexts following the same structure as the value graph. We can achieve horizontal scoping (A class in a collection having the same property name as a sibling but with different semantics) by scoping the nested contexts on @type of each class. Since scoping on types only works for single types, but most of our classes have more than one semantic type, we need to repeat the context for each semantic type of a class, making the context a bit of a mess and unwieldy, but allowing consistent and robust usage of the context everywhere.This PR is not based on master (!), but on PR #765 as it is needed to test that PR and I already started working on it there when I though there was a quick fix possible.
Closes #548