Skip to content

Commit

Permalink
PR review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Zales0123 committed Feb 22, 2016
1 parent b6f4221 commit 52ec41a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/Sylius/Behat/Context/Setup/PromotionContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,6 @@ private function getPriceFromString($price)
*/
private function getPercentageFromString($discount)
{
return ((int) $discount)/100;
return ((int) $discount) / 100;
}
}
4 changes: 2 additions & 2 deletions src/Sylius/Component/Promotion/Factory/ActionFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ public function createFixedDiscount($amount)
/**
* {@inheritdoc}
*/
public function createPercentageDiscount($discount)
public function createPercentageDiscount($percentage)
{
$action = $this->createNew();
$action->setType(ActionInterface::TYPE_PERCENTAGE_DISCOUNT);
$action->setConfiguration(['percentage' => $discount]);
$action->setConfiguration(['percentage' => $percentage]);

return $action;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ interface ActionFactoryInterface extends FactoryInterface
public function createFixedDiscount($amount);

/**
* @param float $discount
* @param float $percentage
*
* @return ActionInterface
*/
public function createPercentageDiscount($discount);
public function createPercentageDiscount($percentage);
}

0 comments on commit 52ec41a

Please # to comment.