[ResourceBundle][proposal/idea]Doctrine driver factory #1087
+806
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| /** @var ContainerBuilder $container */ | ||
| protected $container; | ||
| /** @param string $prefix */ |
|
@jjanvier done! |
| public function __construct($driver, $className) | ||
| { | ||
| parent::__construct(sprintf( | ||
| 'Driver "%s" is unsupported by %s.', |
|
@jjanvier, |
|
Rebased. |
|
Elegant solution, much cleaner 👍 |
|
Very nice Arnaud! 👍 Thank you! |
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 21, 2014
[ResourceBundle][proposal/idea]Doctrine driver factory
|
@Arn0d welcome bro. We'll have to celebrate this 🍻 |
|
@jjanvier yes, next friday... Cuitas les bananas! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[ResourceBundle][proposal/idea]Doctrine driver factory
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a factory for the doctrine driver (defined in the
dependencyInjectordirectory). Before this PR, a factory was 'simulated' in theSyliusResourceExtension. The driver used inBaseExtensionwas hard coded too. The folderFactorywas renamed toDriverbecause it was not really factories IMO. Spec are added too for each Driver.@Sylius, is it a good idea (I hope!)?