Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Maintenance] Prepend Doctrine configuration for smoother update to v3 #13283

Closed
wants to merge 1 commit into from
Closed

[Maintenance] Prepend Doctrine configuration for smoother update to v3 #13283

wants to merge 1 commit into from

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Nov 9, 2021

Q A
Branch? 1.9
Bug fix? yes*
New feature? no
BC breaks? no
Deprecations? no
Related tickets alternative to #13252 & #13275
License MIT

This is alternative approach to register json_array for BC instead of forcing conflict with Doctrine v3

@stloyd stloyd requested a review from a team as a code owner November 9, 2021 17:03
@stloyd
Copy link
Contributor Author

stloyd commented Nov 9, 2021

@lchrusciel @Zales0123 What do you think? (I didn't remove composer.json conflict yet, but wanted to get feedback on code change).

@lchrusciel
Copy link
Contributor

As json and json_array types are almost idiomatic, I would recommend change of the field types instead of aliases

@ernestWarwas ernestWarwas mentioned this pull request Jun 21, 2022
Closed
@jakubtobiasz
Copy link
Contributor

Hi @stloyd!
Thanks for your effort, the issue seems to be resolved in the supported versions of Sylius 💃🏻.

@stloyd stloyd deleted the patch-6 branch February 3, 2023 11:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stloyd @lchrusciel @jakubtobiasz