Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix confirmation modal tests #1421

Merged
merged 1 commit into from
Apr 25, 2014

Conversation

umpirsky
Copy link
Contributor

This is the proof that nobody is running @javascript scenarios. 😄

BTW, why are they not executed on Travis? Why do we have:

    - wget http://selenium-release.storage.googleapis.com/2.41/selenium-server-standalone-2.41.0.jar
    - java -jar selenium-server-standalone-2.41.0.jar > /dev/null &

in travis.yml then?

@stloyd
Copy link
Contributor

stloyd commented Apr 23, 2014

This was already many times "moved-on" cause Paweł never finds enough time to send/test code about whole JS testing done by Arnauld =)

@arnolanglade
Copy link
Contributor

Arnaud :D ! but we need to run them on Travis!

@umpirsky
Copy link
Contributor Author

BTW @Arn0d what is the status of your PR aiming to fix js magic for promotion rules and checkers, many @javascript scenarios are failing because of it. I see this as a critical issue.

/cc @pjedrzejewski

@arnolanglade
Copy link
Contributor

I don't know, Pawel wanted to write some part of this PR.

@umpirsky
Copy link
Contributor Author

@Arn0d @pjedrzejewski Very hard to run scenarios without it. And it is bad for users ofc.

@umpirsky
Copy link
Contributor Author

We should iterate faster, with smaller incremental improvements. Huge PRs like that usually become outdated and never get merged.

@arnolanglade
Copy link
Contributor

@umpirsky : totally agree. Now ,my PR are smaller than it but this one could be merged and modified after. Yes, we should improve our workflow.

@jjanvier
Copy link
Contributor

Oh yes... No more big fatty PR... Couldn't agree more.

@stloyd
Copy link
Contributor

stloyd commented Apr 25, 2014

@pjedrzejewski I guess this can be easily merged for now.

pjedrzejewski pushed a commit that referenced this pull request Apr 25, 2014
@pjedrzejewski pjedrzejewski merged commit be2aed6 into Sylius:master Apr 25, 2014
@pjedrzejewski
Copy link
Member

Thank you Sasha!

@umpirsky umpirsky deleted the fix/confirmation-modal-tests branch April 25, 2014 12:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants