-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix confirmation modal tests #1421
Fix confirmation modal tests #1421
Conversation
This was already many times "moved-on" cause Paweł never finds enough time to send/test code about whole JS testing done by Arnauld =) |
Arnaud :D ! but we need to run them on Travis! |
BTW @Arn0d what is the status of your PR aiming to fix js magic for promotion rules and checkers, many /cc @pjedrzejewski |
I don't know, Pawel wanted to write some part of this PR. |
@Arn0d @pjedrzejewski Very hard to run scenarios without it. And it is bad for users ofc. |
We should iterate faster, with smaller incremental improvements. Huge PRs like that usually become outdated and never get merged. |
@umpirsky : totally agree. Now ,my PR are smaller than it but this one could be merged and modified after. Yes, we should improve our workflow. |
Oh yes... No more big fatty PR... Couldn't agree more. |
@pjedrzejewski I guess this can be easily merged for now. |
Fix confirmation modal tests
Thank you Sasha! |
This is the proof that nobody is running
@javascript
scenarios. 😄BTW, why are they not executed on Travis? Why do we have:
in travis.yml then?