[Resource] Move event into component & add new dependency on it #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you have a look at this CartEvent? There is a fatal on Travis. |
|
@pjedrzejewski Fixed. |
|
@pjedrzejewski @Arn0d What do you think about such move? |
|
@pjedrzejewski @Arn0d Guys, any feedback? |
|
@pjedrzejewski It sounds good! |
stloyd
force-pushed
the
feature/resource_event
branch
from
9103105 to
3be969f
Compare
|
Looks good to me, just requires a rebase. |
stloyd
force-pushed
the
feature/resource_event
branch
from
3be969f to
f0f410b
Compare
|
@pjedrzejewski rebased. |
stloyd
force-pushed
the
feature/resource_event
branch
from
f0f410b to
ffd9028
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Oct 21, 2014
[Resource] Move event into component & add new dependency on it
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow easier usage of the event, and not depending on whole
ResourceBundleto have it.