[RbacBundle] Teach the RbacInitializer to append new permissions #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| foreach ($data['permissions'] as $permission) { | ||
| foreach ($data['permissions'] as $permission) { | ||
| if ( !$role->hasPermission($this->permissionsByCode[$permission]) ) { |
existing roles. Previously, you could basically only use the RbacInitializer once, to create roles with their permissions. If you add new permissions to existing roles (e.g. via configuration like rbac.yml) these won't be added by the initializer. This commit makes the initializer always try to add new permissions to roles, new or old, and updates the console output a bit to reflect the behavior.
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 11, 2015
[RbacBundle] Teach the RbacInitializer to append new permissions
|
Thanks Jim! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you could basically only use the RbacInitializer once, to
create roles with their permissions. If you add new permissions to
existing roles (e.g. via configuration like rbac.yml) these won't be
added by the initializer.
This commit makes the initializer always try to add new permissions to
roles, new or old, and updates the console output a bit to reflect the
behavior.