[User] Remove Symfony security component dependecy #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michalmarcinkowski
commented
Sep 4, 2015
michalmarcinkowski
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no (component hasn't been released yet 😄) |
| Deprecations? | no |
| Fixed tickets | |
| License | MIT |
michalmarcinkowski
force-pushed
the
improve-user-component
branch
from
562bcdc to
dab76af
Compare
| @@ -9,7 +9,7 @@ | |||
| * file that was distributed with this source code. | |||
| */ | |||
|
|
|||
| namespace Sylius\Component\User\Security\Authentication; | |||
| namespace Sylius\Component\UserBundle\Security\Authentication; | |||
There was a problem hiding this comment.
Im pretty sure you ment Sylius\ Bundle \UserBundle\Security\Authentication.
There was a problem hiding this comment.
@lchrusciel meant #justgrammarnazithings :D
There was a problem hiding this comment.
@pamil Of course you are right. My bad. meant*
michalmarcinkowski
force-pushed
the
improve-user-component
branch
from
dab76af to
8546700
Compare
|
I don't see any advantage of removing variables comments, IMO it's fine to leave them, because it makes them clearer. |
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 8, 2015
[User] Remove Symfony security component dependecy
|
Thank you Michal! 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.