PaymentMethodRepository : check if array key exists before checking if value is false #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelvnk
commented
Feb 11, 2016
axelvnk
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #4118 |
| License | MIT |
| @@ -26,7 +26,7 @@ public function getQueryBuidlerForChoiceType(array $options) | |||
| { | |||
| $queryBuilder = $this->getCollectionQueryBuilder(); | |||
|
|
|||
| if (!$options['disabled']) { | |||
| if (array_key_exists('disabled', $options) && !$options['disabled']) { | |||
There was a problem hiding this comment.
Use isset($options['disabled'])
| @@ -26,7 +26,7 @@ public function getQueryBuidlerForChoiceType(array $options) | |||
| { | |||
| $queryBuilder = $this->getCollectionQueryBuilder(); | |||
|
|
|||
| if (!$options['disabled']) { | |||
| if (isset($options['disabled']) && !$options['disabled']) { | |||
| $queryBuilder->where('method.enabled = true'); | |||
michalmarcinkowski
added a commit
that referenced
this pull request
Feb 12, 2016
PaymentMethodRepository : check if array key exists before checking if value is false
|
Thanks Axel! 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.