[Admin] Managing taxons #4866
Merged
[Admin] Managing taxons #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Apr 25, 2016
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
Arminek
force-pushed
the
new-admin-taxon2
branch
from
a443d7b to
214594f
Compare
| form: SyliusAdminBundle:Taxon:_form.html.twig | ||
| type: sylius.resource | ||
|
|
||
| sylius_admin_taxon_index: |
There was a problem hiding this comment.
This action can be removed. ;)
Arminek
force-pushed
the
new-admin-taxon2
branch
5 times, most recently
from
9559276 to
f7aa76e
Compare
Arminek
force-pushed
the
new-admin-taxon2
branch
3 times, most recently
from
e2be435 to
31cae9e
Compare
Arminek
force-pushed
the
new-admin-taxon2
branch
from
31cae9e to
313273c
Compare
| @@ -23,6 +23,8 @@ | |||
| <parameter key="sylius.behat.context.ui.admin.managing_product_options.class">Sylius\Behat\Context\Ui\Admin\ManagingProductOptionsContext</parameter> | |||
| <parameter key="sylius.behat.context.ui.admin.managing_promotions.class">Sylius\Behat\Context\Ui\Admin\ManagingPromotionsContext</parameter> | |||
| <parameter key="sylius.behat.context.ui.admin.managing_shipping_methods.class">Sylius\Behat\Context\Ui\Admin\ManagingShippingMethodsContext</parameter> | |||
| <parameter key="sylius.behat.context.ui.admin.managing_taxons.class">Sylius\Behat\Context\Ui\Admin\ManagingTaxonsContext</parameter> | |||
| <parameter key="sylius.behat.context.ui.admin.managing_tax_category.class">Sylius\Behat\Context\Ui\Admin\ManagingTaxCategoryContext</parameter> | |||
There was a problem hiding this comment.
Should be removed.
| _controller: sylius.controller.taxon:indexAction | ||
| _sylius: | ||
| template: SyliusAdminBundle:Taxon:index.html.twig | ||
| section: admin |
There was a problem hiding this comment.
That is redundant
Arminek
force-pushed
the
new-admin-taxon2
branch
from
ed40ffd to
2cfd42e
Compare
| @@ -23,6 +23,7 @@ | |||
| <parameter key="sylius.behat.context.ui.admin.managing_product_options.class">Sylius\Behat\Context\Ui\Admin\ManagingProductOptionsContext</parameter> | |||
| <parameter key="sylius.behat.context.ui.admin.managing_promotions.class">Sylius\Behat\Context\Ui\Admin\ManagingPromotionsContext</parameter> | |||
| <parameter key="sylius.behat.context.ui.admin.managing_shipping_methods.class">Sylius\Behat\Context\Ui\Admin\ManagingShippingMethodsContext</parameter> | |||
| <parameter key="sylius.behat.context.ui.admin.managing_taxons.class">Sylius\Behat\Context\Ui\Admin\ManagingTaxonsContext</parameter> | |||
There was a problem hiding this comment.
Wrong order, this line should be after ...tax_rate...
Arminek
force-pushed
the
new-admin-taxon2
branch
from
2cfd42e to
f7650d6
Compare
Arminek
force-pushed
the
new-admin-taxon2
branch
from
f7650d6 to
17c3313
Compare
|
Thank you Arek! 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.