Abandon cart on cart clean

[winzou]

I may have missed something, but actually when clearing a cart it's deleted from the database, but not from the session (cartProvider using SessionStorage). So on the next page, CartProvider will do $this->repository->find($identifier); leading to a NotFoundException because the cart has been deleted.

This PR delete the cart identifier from the session. That way, on the next page CartProvider will create a new cart instead of trying to use an unexisting one.

The weird thing is that it's currently working well on the demo, but how? Can't find, even with a grep, where the abandonCart method is called.

[pjedrzejewski]

If you look closely at the cart provider, if the cart with given identifier is not found, there is no exception, it simply creates a new cart and overrides the old identifier. So it works fine right now. That being said, I agree we should remove the deleted identifier together with the cart.

Anyway, I think we should rethink the logic of cart clearing, perhaps removing the whole cart is not a valid approach.

[winzou]

Yeah I've seen that. I got the error because I'd overriden the CartRepository::find() method using getSingleResult in my query instead of getOneOrNullResult. That's why it throws this exception.

But anyway, the identifier should be deleted as well and it's exactly what this PR does ;)

About the logic, I like the current all removing, it ensures all is well deleted and cleaned (think of item, promotion, etc, etc.).

[pjedrzejewski]

Thanks Alexandre!